chore: return response headers in API response #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
ENG-3627
Context / Summary
Adds ability to include response headers from Authlete API Responses.
Description / Changes Made
responseHeadersfield to theApiResponseclassApiResponse, the http headers fromConnectionContextare set to theApiResponseobject.Breaking Changes
No, this approach was chosen with backwards compatibility in mind.
Testing Instructions
retrieve-response-headersofauthlete-java-common,authete-java-jaxrsandjava-oauth-servermvn clean install -Dgpg.skip=truein each directory to make sure the code changes are installed in your local maven repositoryauthlete.propertiesinjava-oauth-serverto use your Authlete 3 service.Send Request. This triggers the/authorizeendpoint to be called.java-oauth-server. You should see a the response headers logged, which include a hardcoded request id that was included in the request.Can use this branch to test:
authlete/java-oauth-server@master...retrieve-response-headers
authlete/authlete-java-jaxrs#54
Added Tests?
No. Tested manually for now as there is no testing infrastructure setup for the network calls.
Related MRs