feat: add grpcutil.AuthzedError to catch sync and async gRPC errors#340
Open
ivanauth wants to merge 2 commits into
Open
feat: add grpcutil.AuthzedError to catch sync and async gRPC errors#340ivanauth wants to merge 2 commits into
ivanauth wants to merge 2 commits into
Conversation
…authzed#14) The previous AuthzedError subclassed Exception and was never raised, so 'except AuthzedError' caught nothing. grpc.aio.AioRpcError already subclasses grpc.RpcError, so alias AuthzedError to grpc.RpcError; a single except now catches errors from both the sync and async clients. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
The sync client raises grpc.RpcError and the async client raises
grpc.aio.AioRpcError. This adds a single name,
grpcutil.AuthzedError,that catches both:
It's a thin alias for grpc.RpcError, which works because
grpc.aio.AioRpcError already subclasses grpc.RpcError - so one
except AuthzedErrorcovers either client. Adds a test asserting botherror types are caught.
Note:
except grpc.RpcErroralready catches both today; this just givesthe SDK a discoverable, branded name for it, as requested in the issue.