feat(memory): add read-only memory commands - #1836
Open
notgitika wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1836 +/- ##
============================================
+ Coverage 94.89% 94.94% +0.04%
============================================
Files 151 155 +4
Lines 7421 7493 +72
============================================
+ Hits 7042 7114 +72
Misses 379 379 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
notgitika
marked this pull request as ready for review
July 27, 2026 19:06
Contributor
Author
|
AI review failing because of a bug. Fix: #1823 |
Hweinstock
reviewed
Jul 28, 2026
Hweinstock
left a comment
Hweinstock
left a comment
Contributor
There was a problem hiding this comment.
one question on TUI behavior, otherwise lgtm.
| description: "get an AgentCore Memory", | ||
| flags: [ | ||
| flag("id", "the ID of the Memory", z.string().optional()), | ||
| flag("view", "response view", z.enum(MEMORY_VIEWS).default("full")), |
Contributor
There was a problem hiding this comment.
does providing a default at this level make still make it possible to open the TUI with no flags? Would the default cause the check in
to fail?| name: "list", | ||
| description: "list AgentCore Memories", | ||
| flags: [ | ||
| flag("next-token", "pagination token returned by a previous request", z.string().optional()), |
Contributor
There was a problem hiding this comment.
OOS here, but curious to others thoughts. Do we think its worth defining a shared flag for stuff like this? We already have the same definitions for runtime, harness, and now memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the first Memory surface to the refactored CLI with Read-only commands.
Users can fetch a Memory with
agentcore memory get --id <memoryId>and list Memories with service-side pagination through--max-resultsand--next-token.getalso supports thefullandwithout_decryptionresponse views.The commands are backed by a feature-scoped core
MemoryClientusing the AWS SDK. This also wires Memory into the root command tree and test client, adds fixture-backed command coverage, and updates the REAMDE.Out of scope: data plane operations, memory mutations, TUI.
Next PR would be: dedicated TUI flows
Ran the bun CI checks and
bun buildsuccessfully.Manually tested all these commands E2E on my account and they were all successful and working as expected