Skip to content

fix: make data table columns terminal-aware - #1845

Open
aidandaly24 wants to merge 6 commits into
refactorfrom
fix/data-table-column-widths
Open

fix: make data table columns terminal-aware#1845
aidandaly24 wants to merge 6 commits into
refactorfrom
fix/data-table-column-widths

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Make DataTable allocate columns from terminal width so picker tables fill the screen without wrapping or welding adjacent fields.

Changes

  • add a pure shrink-then-drop width allocator with structural one-cell column gaps
  • add explicit fixed/flex column sizing metadata to all six Runtime and Harness picker configurations
  • require an explicit fixed width, default minWidth to it, and keep allocator internals private to DataTable
  • represent dropped columns directly through omitted computed widths
  • render full version headers and verify every visible production header fits its allocated width
  • render compact UTC timestamps and the discriminating Runtime ID suffix
  • preserve both rendered-value and raw-value filtering
  • use display-cell-aware truncation for Unicode and ANSI-safe output
  • remove unreachable interactive sorting inherited from the previous table implementation
  • replace the unused @inkui-cli/data-table dependency with direct cli-truncate and string-width dependencies

Validation

  • bun install --frozen-lockfile
  • bun test (403 passed)
  • bun test --coverage --coverage-reporter=lcov
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • bun audit
  • bun pm pack --destination /tmp

Live deploy-profile TUI validation in us-east-1:

  • reproduced the base-branch failure at 80 columns: wrapped headers/rows, welded fields, and pagination text overlaid with table data
  • verified Runtime list tables exactly fill 60, 80, and 120 columns with one physical line per row
  • verified Harness list tables exactly fill 80 columns
  • verified filtering by a rendered compact UTC timestamp returns the expected live Runtime row

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 27, 2026
@codecov-commenter

codecov-commenter commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (21353dd) to head (1215f5d).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1845      +/-   ##
============================================
+ Coverage     95.00%   95.21%   +0.20%     
============================================
  Files           161      163       +2     
  Lines          7691     7810     +119     
============================================
+ Hits           7307     7436     +129     
+ Misses          384      374      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 27, 2026
@aidandaly24
aidandaly24 force-pushed the fix/data-table-column-widths branch from 3e4e060 to 96ee5c2 Compare July 28, 2026 14:25
@aidandaly24
aidandaly24 marked this pull request as ready for review July 28, 2026 14:44
Comment thread src/components/ui/data-table/DataTable.tsx Outdated
Comment thread src/components/ui/data-table/DataTable.tsx Outdated
Comment thread src/components/ui/data-table/columnWidths.ts Outdated
Comment thread src/components/ui/data-table/columnWidths.ts Outdated
Comment thread src/components/ui/data-table/columnWidths.ts
Comment thread src/components/ui/data-table/columnWidths.ts Outdated
Comment thread src/components/RuntimeEndpointPicker.tsx Outdated
@aidandaly24
aidandaly24 force-pushed the fix/data-table-column-widths branch from dbe4518 to 1215f5d Compare July 29, 2026 04:15
@@ -0,0 +1,5 @@
export function formatTimestamp(value: unknown): string {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like how this cleans up the UI a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants