fix: make data table columns terminal-aware - #1845
Open
aidandaly24 wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1845 +/- ##
============================================
+ Coverage 95.00% 95.21% +0.20%
============================================
Files 161 163 +2
Lines 7691 7810 +119
============================================
+ Hits 7307 7436 +129
+ Misses 384 374 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aidandaly24
force-pushed
the
fix/data-table-column-widths
branch
from
July 28, 2026 14:25
3e4e060 to
96ee5c2
Compare
aidandaly24
marked this pull request as ready for review
July 28, 2026 14:44
aidandaly24
commented
Jul 28, 2026
Hweinstock
reviewed
Jul 28, 2026
aidandaly24
force-pushed
the
fix/data-table-column-widths
branch
from
July 29, 2026 04:15
dbe4518 to
1215f5d
Compare
Hweinstock
approved these changes
Jul 29, 2026
| @@ -0,0 +1,5 @@ | |||
| export function formatTimestamp(value: unknown): string { | |||
Contributor
There was a problem hiding this comment.
i like how this cleans up the UI a bit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
DataTableallocate columns from terminal width so picker tables fill the screen without wrapping or welding adjacent fields.Changes
minWidthto it, and keep allocator internals private toDataTableversionheaders and verify every visible production header fits its allocated width@inkui-cli/data-tabledependency with directcli-truncateandstring-widthdependenciesValidation
bun install --frozen-lockfilebun test(403 passed)bun test --coverage --coverage-reporter=lcovbun run typecheckbun run lint:checkbun run format:checkbun run buildbun auditbun pm pack --destination /tmpLive deploy-profile TUI validation in
us-east-1: