fix(templates): avoid pulling in incompatible mcp versions - #1850
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1850-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.24.2.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Hweinstock
marked this pull request as ready for review
July 28, 2026 18:11
nborges-aws
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The e2e tests are failing on mainline for the past few days with langgraph templates. Ex. https://github.com/aws/agentcore-cli/actions/runs/30370526485/job/90338758015
Confirmed with a local test that
agentcore createwith a langGraph python bedrock agent, thenagentcore deployfollowed byagentcore invokeproducesError: Runtime initialization time exceeded. Please make sure that initialization completes in 30s.on the live released CLI and the unreleased version.This confirms the issue happened without a code change on the CLI side since previous tests were passing 19 hours ago: https://github.com/aws/agentcore-cli/actions/runs/30306941476/job/90113364343.
Root Cause
We do not pin a dependency in the langgraph template that recently had a major version update.
Solution
langchain-mcp-adapters 0.3.xexpects it to be under this name.langchain-mcp-adaptersto ensure its compatible with bump to mcp package done above.Notes
When making this change, I noticed that there are other unpinned dependencies in these templates. We should make an effort to move these towards pinning to avoid this happening moving forward. However, we need to be careful when pinning since it could cause us to use a different version than what is currently being resolved. Creating a follow-up GH issue for this work that we should tackle as part of the refactor.
Testing
langgraph-openai.test.tslocally.