fix(deps): patch fast-uri and brace-expansion to clear audit gate - #1903
Merged
Conversation
The security job in Quality and Safety Checks runs `npm audit --audit-level=high --omit=dev` and has been failing on main with two high-severity findings in the production tree: - fast-uri 3.1.4 (via ajv) — GHSA-7p8r-x3mc-p8w7, host confusion via backslash authority introducer. Advisory covers 3.0.0 - 3.1.4, so 3.1.5 is the first patched release. - brace-expansion 5.0.8 — GHSA-rgw5-rvv9-x895, DoS via unbounded intermediate arrays that bypasses the CVE-2026-14257 mitigation. Advisory covers 4.0.0 - 5.0.8. Both are transitive and already in range for their parents, so this is a shrinkwrap-only change with no package.json edit. Pinned to just these two packages rather than running a blanket `npm audit fix`, which additionally bumped @aws-sdk/core, @smithy/core (a minor), and @smithy/signature-v4 — none of which are covered by an advisory. Also corrects pre-existing drift where the shrinkwrap root recorded 0.24.2 while package.json is 0.25.0; any package-lock regeneration rewrites it, so it cannot be avoided in this diff. Verified: npm audit --audit-level=high --omit=dev exits 0, and npm ci installs the tree cleanly (integrity hashes verified against the registry tarballs).
Contributor
Package TarballHow to installgh release download pr-1903-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.25.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Coverage Report
|
aidandaly24
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the
securityjob in Quality and Safety Checks, which has been failing onmain.npm run security:audit(npm audit --audit-level=high --omit=dev) reports two high-severity findings in the production tree:fast-uri(viaajv)3.0.0 - 3.1.4brace-expansion4.0.0 - 5.0.8Both are transitive and already in range for their parents, so this is shrinkwrap-only — no
package.jsonedit, no major bump.Notes for review
Pinned deliberately, not
npm audit fix. A blanketnpm audit fixalso bumped@aws-sdk/core3.977.1→3.977.5,@smithy/core3.30.0→3.31.1 (a minor), and@smithy/signature-v45.6.10→5.6.12 — none covered by an advisory. Those are left for a deliberate SDK bump.The root version line is a drift correction, not a version bump.
package.jsonis already0.25.0but the shrinkwrap root recorded0.24.2, so a previous version bump landed without regenerating the shrinkwrap. Anynpm install --package-lock-onlyrewrites it, so it rides along here unavoidably.Remaining moderate findings are out of scope.
fast-xml-parserand the@opentelemetry/*tree are moderate, below the--audit-level=highthreshold, so they do not gate. Clearing them requires an@aws-sdkbump — separate PR.Testing
Against current
main(1afa008):resolvedandintegrityare preserved for both packages, verified against the published tarballs.