Skip to content

fix(deps): patch fast-uri and brace-expansion to clear audit gate - #1903

Merged
jariy17 merged 1 commit into
mainfrom
fix/audit-shrinkwrap
Aug 4, 2026
Merged

fix(deps): patch fast-uri and brace-expansion to clear audit gate#1903
jariy17 merged 1 commit into
mainfrom
fix/audit-shrinkwrap

Conversation

@jariy17

@jariy17 jariy17 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Unblocks the security job in Quality and Safety Checks, which has been failing on main.

npm run security:audit (npm audit --audit-level=high --omit=dev) reports two high-severity findings in the production tree:

Package On main Fix Advisory
fast-uri (via ajv) 3.1.4 3.1.5 GHSA-7p8r-x3mc-p8w7 — host confusion via backslash authority introducer, range 3.0.0 - 3.1.4
brace-expansion 5.0.8 5.0.9 GHSA-rgw5-rvv9-x895 — DoS via unbounded intermediate arrays, bypassing the CVE-2026-14257 mitigation, range 4.0.0 - 5.0.8

Both are transitive and already in range for their parents, so this is shrinkwrap-only — no package.json edit, no major bump.

Notes for review

Pinned deliberately, not npm audit fix. A blanket npm audit fix also bumped @aws-sdk/core 3.977.1→3.977.5, @smithy/core 3.30.0→3.31.1 (a minor), and @smithy/signature-v4 5.6.10→5.6.12 — none covered by an advisory. Those are left for a deliberate SDK bump.

The root version line is a drift correction, not a version bump. package.json is already 0.25.0 but the shrinkwrap root recorded 0.24.2, so a previous version bump landed without regenerating the shrinkwrap. Any npm install --package-lock-only rewrites it, so it rides along here unavoidably.

Remaining moderate findings are out of scope. fast-xml-parser and the @opentelemetry/* tree are moderate, below the --audit-level=high threshold, so they do not gate. Clearing them requires an @aws-sdk bump — separate PR.

Testing

Against current main (1afa008):

$ npm audit --audit-level=high --omit=dev
found 0 vulnerabilities   # exit 0

$ npm ci --ignore-scripts   # exit 0, integrity verified against registry tarballs
$ cat node_modules/ajv/node_modules/fast-uri/package.json | jq -r .version
3.1.5
$ cat node_modules/brace-expansion/package.json | jq -r .version
5.0.9

resolved and integrity are preserved for both packages, verified against the published tarballs.

The security job in Quality and Safety Checks runs
`npm audit --audit-level=high --omit=dev` and has been failing on main
with two high-severity findings in the production tree:

  - fast-uri 3.1.4 (via ajv) — GHSA-7p8r-x3mc-p8w7, host confusion via
    backslash authority introducer. Advisory covers 3.0.0 - 3.1.4, so
    3.1.5 is the first patched release.
  - brace-expansion 5.0.8 — GHSA-rgw5-rvv9-x895, DoS via unbounded
    intermediate arrays that bypasses the CVE-2026-14257 mitigation.
    Advisory covers 4.0.0 - 5.0.8.

Both are transitive and already in range for their parents, so this is a
shrinkwrap-only change with no package.json edit.

Pinned to just these two packages rather than running a blanket
`npm audit fix`, which additionally bumped @aws-sdk/core,
@smithy/core (a minor), and @smithy/signature-v4 — none of which are
covered by an advisory.

Also corrects pre-existing drift where the shrinkwrap root recorded
0.24.2 while package.json is 0.25.0; any package-lock regeneration
rewrites it, so it cannot be avoided in this diff.

Verified: npm audit --audit-level=high --omit=dev exits 0, and npm ci
installs the tree cleanly (integrity hashes verified against the
registry tarballs).
@jariy17
jariy17 requested a review from a team August 4, 2026 16:17
@github-actions github-actions Bot added the size/xs PR size: XS label Aug 4, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.25.0.tgz

How to install

gh release download pr-1903-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.25.0.tgz

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 4, 2026
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.44% 15151 / 37462
🔵 Statements 39.71% 16158 / 40680
🔵 Functions 34.69% 2596 / 7482
🔵 Branches 33.82% 10108 / 29882
Generated in workflow #4297 for commit a21c022 by the Vitest Coverage Report Action

@jariy17
jariy17 merged commit 2f27f55 into main Aug 4, 2026
34 of 35 checks passed
@jariy17
jariy17 deleted the fix/audit-shrinkwrap branch August 4, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants