feat(eval): add --model-provider to imperative evaluator create/update - #2299
Conversation
Bug bash — imperative evaluator commands (live, sandbox account, us-west-2)Recorded with the TUI harness against a live AgentCore account. All cases verified end-to-end; the created evaluators were deleted afterward (no residue).
Baseline Bedrock create/get/update/delete unchanged and green. A screen recording of this run is archived internally (Artifactory); it is not linked here because this repository is public. |
08361c7 to
1a0163c
Compare
1a0163c to
7d5a4bf
Compare
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2299 +/- ##
============================================
- Coverage 97.26% 97.25% -0.02%
============================================
Files 610 610
Lines 40590 40656 +66
============================================
+ Hits 39480 39540 +60
- Misses 1110 1116 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude Security Review: no high-confidence findings. (run) |
63d05ef to
7d5a4bf
Compare
|
Claude Security Review: no high-confidence findings. (run) |
7d5a4bf to
0e1c57e
Compare
|
Claude Security Review: no high-confidence findings. (run) |
|
Failing CI test |
notgitika
left a comment
There was a problem hiding this comment.
The description mentioned this test file .../core/evalEvaluatorProvider.test.tsx which is not here was it meant to be included?
| flag( | ||
| "model", | ||
| "judge model: a Bedrock model ID / ARN, or an OpenResponses model ID", | ||
| z.string().min(1), |
There was a problem hiding this comment.
can we reuse the provider-specific model validation from project add evaluator here and in the update path?
string min 1 means at this point " " would be valid. not a blocker imo
|
I forgot to update the PR descriptions, |
|
Claude Security Review: no high-confidence findings. (run) |
This reverts commit ee4ce2c.
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: no high-confidence findings. (run) |
What
Adds
--model-provider(Bedrock default / OpenResponses) to the imperativeagentcore eval evaluator llm-as-a-judge createandupdatecommands, and makesupdateprovider-safe.Verification
bun test .../sharedFlags.test.tsx .../core/evalEvaluatorProvider.test.tsx— 15 pass (provider resolution, arm construction, and the update-safety matrix: model-only Bedrock preserves tuning; instructions-only OpenResponses stays on the responses arm; provider switch requires a model; switch selects the correct arm without leaking the old tuning).evaluator.test.tsx— 32 pass (Bedrock path unchanged).bun run typecheck+bun run lint:checkclean; create/update--helplist both providers.Follow-ups
evaluator.test.tsxrequire recording against an account with OpenResponses access (bug-bash item).modelProvider: OpenResponsesis handled by@aws/agentcore-cdkin the generated app; deploy-time verification in the bug-bash notes.Bug-bash recording against the explore account to follow in a comment.