Skip to content

Add acquireAsync#7149

Open
dagnir wants to merge 4 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt2
Open

Add acquireAsync#7149
dagnir wants to merge 4 commits into
feature/master/adaptive-retries-fixesfrom
dongie/adaptive-fix-pt2

Conversation

@dagnir

@dagnir dagnir commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

This commit replaces tryAcquire with acquireAsync to better support async codepaths. acquireAsync returns a CompletableFuture that is completed when a token is successfully acquired; unlike tryAcquire, the caller is not expected to do any of their own waiting once future is complete.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch from 378a48f to 7f0e04e Compare July 15, 2026 01:09
@dagnir dagnir changed the title Add acquireTokenAsync Add acquireAsync Jul 15, 2026
@dagnir
dagnir marked this pull request as ready for review July 15, 2026 01:11
@dagnir
dagnir requested a review from a team as a code owner July 15, 2026 01:11
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch 3 times, most recently from 236b1d6 to 8d70fdc Compare July 15, 2026 23:10
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch from 8d70fdc to 1d6955d Compare July 16, 2026 20:01
This commit replaces tryAcquire with acquireAsync to better support
async codepaths. acquireAsync returns a CompletableFuture that is
completed when a token is successfully acquired; unlike tryAcquire, the
caller is not expected to do any of their own waiting once future is
complete.
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch from 1d6955d to 561a696 Compare July 16, 2026 20:05
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch 2 times, most recently from 34556cd to 3057f92 Compare July 17, 2026 19:55
@dagnir
dagnir force-pushed the dongie/adaptive-fix-pt2 branch from 3057f92 to b6e57af Compare July 17, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants