[EndpointUri PR 2/4] Switch runtime consumers to EndpointUrl#7158
Merged
alextwoods merged 2 commits intoJul 17, 2026
Merged
Conversation
…date EndpointResolutionStage to call endpoint.endpointUrl() instead of endpoint.url(), eliminating URI construction from the request pipeline hot path. Update addHostPrefix in AwsEndpointProviderUtils to use EndpointUrl components directly, preserving query and fragment via EndpointUrl.fromComponents(5-arg). Add tests for port propagation and encoded path preservation.
alextwoods
force-pushed
the
alexwoo/endpoint-remove-uri-pr2
branch
from
July 16, 2026 20:26
9df96a8 to
aed84e8
Compare
alextwoods
commented
Jul 16, 2026
| } | ||
|
|
||
| @Test | ||
| void execute_resolvedEndpointWithPort_appliesPort() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
There are a number of existing tests that cover the setUri behavior, this is just adding coverage for a few cases that weren't well covered before.
RanVaknin
approved these changes
Jul 17, 2026
alextwoods
merged commit Jul 17, 2026
1bfd0c0
into
feature/master/endpoint-remove-uri
3 of 4 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2/4 for replacing Uri.create in endpoint resoultion with the light weight EndpointUrl.
Note: This PR merges to feature/master/endpoint-remove-uri and NOT to master
Previous PRs:
Modifications
Switch runtime consumers to use EndpointUrl:
Testing
New and existing tests.
Screenshots (if appropriate)
License