Skip to content

fix(memory-integ): address capacity cap and update failures in tests - #604

Merged
Hweinstock merged 2 commits into
mainfrom
fix/integ
Jul 28, 2026
Merged

fix(memory-integ): address capacity cap and update failures in tests#604
Hweinstock merged 2 commits into
mainfrom
fix/integ

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Failing integ tests on main: https://github.com/aws/bedrock-agentcore-sdk-python/actions/runs/30303039785/job/90288106089.

Problem

Failing integ tests on main: https://github.com/aws/bedrock-agentcore-sdk-python/actions/runs/30303039785/job/90288106089 with two root causes:

  • add_strategy(wait_for_active=True) only waited for the strategy to reach ACTIVE, but the memory itself could still be in UPDATING state. Consecutive add_strategy calls (as in test_add_strategy_immediately_after_another) would hit ValidationException: Memory is in transitional state UPDATING.
  • CI account hit memory limit with 150.

Solution

After the strategy is confirmed ACTIVE, add_strategy now also checks the memory status and waits for it to return to ACTIVE using the existing _wait_for_memory_active utility.

Testing

  • All 6 integ tests pass against dev account (previously test 4 failed consistently)

Notes

there appears to be an issue with PRs from forks: #603 so make this from origin branch.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No Breaking Changes Detected

No public API breaking changes found in this PR.

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jul 28, 2026
@Hweinstock

Copy link
Copy Markdown
Contributor Author
FAILED tests_integ/evaluation/test_dataset_client.py::TestDatasetCrud::test_create_dataset_and_wait_inline - botocore.errorfactory.ConflictException: An error occurred (ConflictException) when calling the CreateDataset operation: A dataset with this name already exists in your account. Please choose a different name and try again.

evaluator failure is likely a flaky test, can track as a follow-up.

@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jul 28, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review July 28, 2026 14:56
@Hweinstock
Hweinstock requested a review from a team July 28, 2026 14:56
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jul 28, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Jul 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 28, 2026
@Hweinstock
Hweinstock merged commit 59cbff3 into main Jul 28, 2026
40 of 42 checks passed
@Hweinstock
Hweinstock deleted the fix/integ branch July 28, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants