Skip to content

refactor(agui): build agent directly in entrypoint, make Memory optional#113

Open
razkenari wants to merge 1 commit into
mainfrom
feat/agui-agents-simplify-entrypoint
Open

refactor(agui): build agent directly in entrypoint, make Memory optional#113
razkenari wants to merge 1 commit into
mainfrom
feat/agui-agents-simplify-entrypoint

Conversation

@razkenari

Copy link
Copy Markdown
Contributor

Simplify both AG-UI patterns by removing the ActorAware* subclasses and instantiating the framework agent directly inside @app.entrypoint. Memory is now opt-in: the helper returns None when MEMORY_ID is unset, so the patterns run without provisioning AgentCore Memory.

  • Move model and Code Interpreter setup to module load
  • Rename user_id to actor_id for consistency

@razkenari razkenari requested a review from a team May 31, 2026 02:31
@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

Latest scan for commit: 7a764db | Updated: 2026-05-31 02:42:14 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2026-05-31T02:42:02+00:00
  • ASH version: 3.2.2

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 0 0 442ms 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 33.0s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 38ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 5.2s 0 PASSED MED (g)
detect-secrets 0 0 0 0 0 0 168ms 0 PASSED MED (g)
grype 0 0 0 0 0 0 49.1s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 455ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 20.3s 0 PASSED MED (g)
semgrep 0 0 0 0 0 0 <1ms 0 MISSING MED (g)
syft 0 0 0 0 0 0 2.3s 0 PASSED MED (g)

Simplify both AG-UI patterns by removing the ActorAware* subclasses and
instantiating the framework agent directly inside @app.entrypoint. Memory
is now opt-in: the helper returns None when MEMORY_ID is unset, so the
patterns run without provisioning AgentCore Memory.

- Move model and Code Interpreter setup to module load
- Rename user_id to actor_id for consistency
- Use AWS_REGION instead of AWS_DEFAULT_REGION
@razkenari razkenari force-pushed the feat/agui-agents-simplify-entrypoint branch from a599f0b to 7a764db Compare May 31, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant