feat(fetch): Add WPT tests and improve FormData compatibility#1637
Open
nabetti1720 wants to merge 3 commits into
Open
feat(fetch): Add WPT tests and improve FormData compatibility#1637nabetti1720 wants to merge 3 commits into
nabetti1720 wants to merge 3 commits into
Conversation
richarddavison
requested changes
Jun 30, 2026
richarddavison
left a comment
richarddavison
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this! Small suggestion!
richarddavison
force-pushed
the
feat/improve-formdata
branch
2 times, most recently
from
b4b188d to
6c67ffd
Compare
richarddavison
force-pushed
the
feat/improve-formdata
branch
2 times, most recently
from
858b6e0 to
7576813
Compare
Replace the snapshot-based iterators with live, index-based ones that observe mutations during iteration (WebIDL semantics), fixing the xhr/formdata iteration.any.js WPT test. A single LiveIterator class in llrt_utils holds the backing collection as a JS value plus a function that reads its entries, so Headers, FormData, and URLSearchParams share one iterator type. Drop the now-unused IteratorDef trait and map_to_entries helper.
richarddavison
force-pushed
the
feat/improve-formdata
branch
from
7576813 to
cf08179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
n/a
Description of changes
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.