Add an iOS withDangerousMod to the Expo config plugin that patches RCTThirdPartyComponentsProvider.mm

.gitignore

@@ -76,3 +76,4 @@ android/keystores/debug.keystore
 
 # generated by bob
 lib/
+/azesmway-react-native-unity-*.tgz

README.md

@@ -19,8 +19,6 @@ Attention! Added support for Unity 2023 and above
 
 # Installation
 
-## Install this package in your react-native project:
-
 ```sh
 npm install @azesmway/react-native-unity
 
@@ -29,6 +27,20 @@ or
 yarn add @azesmway/react-native-unity
 ```
 
+For Expo projects (SDK 48+)
+
+1. Run prebuild
+```sh
+npx expo prebuild --clean
+```
+2. Build your app
+```sh
+npx expo run:ios
+```
+
+**Note for Expo users**: The UnityFramework must be placed at `<project_root>/unity/builds/ios/` before running `expo prebuild`.
+
+
 ## Configure your Unity project:
 
 1. Copy the contents of the folder `unity` to the root of your Unity project. This folder contains the necessary scripts and settings for the Unity project. You can find these files in your react-native project under `node_modules/@azesmway/react-native-unity/unity`. This is necessary to ensure iOS has access to the `NativeCallProxy` class from this library.
@@ -179,6 +191,20 @@ const Unity = () => {
 export default Unity;
 ```
 
+## Automatic Setup with Expo Config Plugin
+
+Add the plugin to your `app.json`:
+
+```json
+{
+  "expo": {
+    "plugins": [
+      "@azesmway/react-native-unity"
+    ]
+  }
+}
+```
+
 ## Props
 
 - `style: ViewStyle` - styles the UnityView. (Won't show on Android without dimensions. Recommended to give it `flex: 1` as in the example)

android/build.gradle

@@ -98,7 +98,6 @@ repositories {
   }
   google()
   mavenCentral()
-  jcenter()
 }
 
 

android/src/main/java/com/azesmwayreactnativeunity/ReactNativeUnityView.java

@@ -59,6 +59,12 @@ protected void onConfigurationChanged(Configuration newConfig) {
   @Override
   protected void onDetachedFromWindow() {
     if (!this.keepPlayerMounted) {
+        // Pause Unity before moving to background so the render thread stops
+        // producing frames before the surface is destroyed, preventing:
+        // BufferQueueProducer disconnect: not connected
+        if (view != null) {
+            view.pause();
+        }
         try {
             addUnityViewToBackground();
         } catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException e) {

android/src/main/java/com/azesmwayreactnativeunity/ReactNativeUnityViewManager.java

@@ -3,29 +3,30 @@
 import static com.azesmwayreactnativeunity.ReactNativeUnity.*;
 
 import android.os.Handler;
+import android.util.Log;
 import android.view.View;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
 import com.facebook.infer.annotation.Assertions;
-import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.LifecycleEventListener;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReadableArray;
-import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.common.MapBuilder;
 import com.facebook.react.module.annotations.ReactModule;
 import com.facebook.react.uimanager.ThemedReactContext;
+import com.facebook.react.uimanager.UIManagerHelper;
 import com.facebook.react.uimanager.annotations.ReactProp;
-import com.facebook.react.uimanager.events.RCTEventEmitter;
+import com.facebook.react.uimanager.events.EventDispatcher;
 
 import java.lang.reflect.InvocationTargetException;
 import java.util.Map;
 
 @ReactModule(name = ReactNativeUnityViewManager.NAME)
 public class ReactNativeUnityViewManager extends ReactNativeUnityViewManagerSpec<ReactNativeUnityView> implements LifecycleEventListener, View.OnAttachStateChangeListener {
+  private static final String TAG = "ReactNativeUnity";
   ReactApplicationContext context;
   static ReactNativeUnityView view;
   public static final String NAME = "RNUnityView";
@@ -45,13 +46,17 @@ public String getName() {
   @NonNull
   @Override
   public ReactNativeUnityView createViewInstance(@NonNull ThemedReactContext context) {
-    view = new ReactNativeUnityView(this.context);
+    // Use ThemedReactContext (not ReactApplicationContext) so Fabric can correctly associate
+    // this view with its surface and apply layout dimensions via Yoga.
+    view = new ReactNativeUnityView(context);
     view.addOnAttachStateChangeListener(this);
 
     if (getPlayer() != null) {
         try {
             view.setUnityPlayer(getPlayer());
-        } catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException e) {}
+        } catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException e) {
+            Log.e(TAG, "setUnityPlayer failed", e);
+        }
     } else {
         try {
             createPlayer(context.getCurrentActivity(), new UnityPlayerCallback() {
@@ -62,21 +67,17 @@ public void onReady() throws InvocationTargetException, NoSuchMethodException, I
 
               @Override
               public void onUnload() {
-                WritableMap data = Arguments.createMap();
-                data.putString("message", "MyMessage");
-                ReactContext reactContext = (ReactContext) view.getContext();
-                reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(view.getId(), "onPlayerUnload", data);
+                dispatchEvent(view, "onPlayerUnload", "");
               }
 
               @Override
               public void onQuit() {
-                WritableMap data = Arguments.createMap();
-                data.putString("message", "MyMessage");
-                ReactContext reactContext = (ReactContext) view.getContext();
-                reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(view.getId(), "onPlayerQuit", data);
+                dispatchEvent(view, "onPlayerQuit", "");
               }
             });
-        } catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException e) {}
+        } catch (InvocationTargetException | NoSuchMethodException | IllegalAccessException e) {
+            Log.e(TAG, "createPlayer failed", e);
+        }
     }
 
     return view;
@@ -139,8 +140,7 @@ public void unloadUnity(ReactNativeUnityView view) {
   @Override
   public void pauseUnity(ReactNativeUnityView view, boolean pause) {
     if (isUnityReady()) {
-      assert getPlayer() != null;
-      getPlayer().pause();
+      if (pause) { pause(); } else { resume(); }
     }
   }
 
@@ -160,17 +160,56 @@ public void windowFocusChanged(ReactNativeUnityView view, boolean hasFocus) {
     }
   }
 
+  private static void dispatchEvent(ReactNativeUnityView view, String eventName, String message) {
+    if (view == null) { Log.e(TAG, "dispatchEvent: null view for " + eventName); return; }
+    android.content.Context viewCtx = view.getContext();
+    ReactContext ctx = (ReactContext) viewCtx;
+    if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
+      int surfaceId;
+      try {
+        // Primary: walk the view's parent chain to find the ReactRoot.
+        surfaceId = UIManagerHelper.getSurfaceId(view);
+      } catch (IllegalStateException e) {
+        // UIManagerHelper walks the view hierarchy which can fail if Unity's frame reparenting
+        // detached the view from its Fabric root. Use ThemedReactContext.getSurfaceId() directly
+        // since it holds the surface ID assigned at view creation time.
+        if (viewCtx instanceof ThemedReactContext) {
+          surfaceId = ((ThemedReactContext) viewCtx).getSurfaceId();
+          Log.d(TAG, "dispatchEvent: surfaceId from ThemedReactContext=" + surfaceId + " for " + eventName);
+        } else {
+          Log.w(TAG, "dispatchEvent: no surfaceId available for " + eventName + ", dropping");
+          return;
+        }
+      }
+      EventDispatcher ed = UIManagerHelper.getEventDispatcherForReactTag(ctx, view.getId());
+      if (ed != null) ed.dispatchEvent(new UnityEvent(eventName, message, surfaceId, view.getId()));
+      else Log.e(TAG, "No EventDispatcher for " + eventName);
+    } else {
+      com.facebook.react.bridge.WritableMap data = com.facebook.react.bridge.Arguments.createMap();
+      data.putString("message", message);
+      ctx.getJSModule(com.facebook.react.uimanager.events.RCTEventEmitter.class)
+         .receiveEvent(view.getId(), eventName, data);
+    }
+  }
+
   public static void sendMessageToMobileApp(String message) {
-    WritableMap data = Arguments.createMap();
-    data.putString("message", message);
-    ReactContext reactContext = (ReactContext) view.getContext();
-    reactContext.getJSModule(RCTEventEmitter.class).receiveEvent(view.getId(), "onUnityMessage", data);
+    if (view == null) { return; }
+    // Unity calls this from its own native thread. UIManagerHelper calls in dispatchEvent
+    // are not thread-safe from non-main threads, so post to the main thread.
+    final ReactNativeUnityView currentView = view;
+    new Handler(android.os.Looper.getMainLooper()).post(new Runnable() {
+      @Override
+      public void run() {
+        if (currentView != null) dispatchEvent(currentView, "onUnityMessage", message);
+      }
+    });
   }
 
   @Override
   public void onDropViewInstance(ReactNativeUnityView view) {
     view.removeOnAttachStateChangeListener(this);
     super.onDropViewInstance(view);
+    if (ReactNativeUnityViewManager.view == view) { ReactNativeUnityViewManager.view = null; }
   }
 
   @Override

android/src/main/java/com/azesmwayreactnativeunity/UPlayer.java

@@ -2,6 +2,7 @@
 
 import android.app.Activity;
 import android.content.res.Configuration;
+import android.util.Log;
 import android.widget.FrameLayout;
 
 import com.unity3d.player.*;
@@ -11,20 +12,56 @@
 import java.lang.reflect.Method;
 
 public class UPlayer {
+    private static final String TAG = "ReactNativeUnity";
     private static UnityPlayer unityPlayer;
 
-    public UPlayer(final Activity activity, final ReactNativeUnity.UnityPlayerCallback callback) throws ClassNotFoundException, InvocationTargetException, IllegalAccessException, InstantiationException {
+    public UPlayer(final Activity activity, final ReactNativeUnity.UnityPlayerCallback callback) throws ClassNotFoundException, InvocationTargetException, IllegalAccessException, InstantiationException, NoSuchMethodException {
         super();
         Class<?> _player = null;
 
         try {
             _player = Class.forName("com.unity3d.player.UnityPlayerForActivityOrService");
+            Log.d(TAG, "UPlayer: using UnityPlayerForActivityOrService");
         } catch (ClassNotFoundException e) {
             _player = Class.forName("com.unity3d.player.UnityPlayer");
+            Log.d(TAG, "UPlayer: using UnityPlayer");
         }
 
-        Constructor<?> constructor = _player.getConstructors()[1];
-        unityPlayer = (UnityPlayer) constructor.newInstance(activity, new IUnityPlayerLifecycleEvents() {
+        // Log all available constructors to aid debugging on new Android versions.
+        Constructor<?>[] allConstructors = _player.getConstructors();
+        Log.d(TAG, "UPlayer: found " + allConstructors.length + " public constructor(s) for " + _player.getName());
+        for (Constructor<?> c : allConstructors) {
+            Log.d(TAG, "UPlayer:   " + c.toGenericString());
+        }
+
+        // Prefer the 2-arg constructor (Context/Activity, IUnityPlayerLifecycleEvents).
+        Constructor<?> constructor = null;
+        for (Constructor<?> c : allConstructors) {
+            Class<?>[] params = c.getParameterTypes();
+            if (params.length == 2 && params[1].isAssignableFrom(IUnityPlayerLifecycleEvents.class)) {
+                constructor = c;
+                break;
+            }
+        }
+
+        // Fallback: some Unity versions may have added a 3rd parameter constructor.
+        if (constructor == null) {
+            for (Constructor<?> c : allConstructors) {
+                Class<?>[] params = c.getParameterTypes();
+                if (params.length >= 2 && params[1].isAssignableFrom(IUnityPlayerLifecycleEvents.class)) {
+                    Log.w(TAG, "UPlayer: falling back to " + params.length + "-param constructor");
+                    constructor = c;
+                    break;
+                }
+            }
+        }
+
+        if (constructor == null) {
+            Log.e(TAG, "UPlayer: no suitable constructor found — Unity SDK may be incompatible");
+            throw new NoSuchMethodException("No matching UnityPlayer constructor found");
+        }
+
+        final IUnityPlayerLifecycleEvents lifecycleEvents = new IUnityPlayerLifecycleEvents() {
             @Override
             public void onUnityPlayerUnloaded() {
                 callback.onUnload();
@@ -34,7 +71,27 @@ public void onUnityPlayerUnloaded() {
             public void onUnityPlayerQuitted() {
                 callback.onQuit();
             }
-        });
+        };
+
+        try {
+            if (constructor.getParameterTypes().length == 2) {
+                unityPlayer = (UnityPlayer) constructor.newInstance(activity, lifecycleEvents);
+            } else {
+                // 3+ param constructor: pass null for extra params and hope for the best;
+                // realistically this branch means the Unity SDK needs an update.
+                Object[] args = new Object[constructor.getParameterTypes().length];
+                args[0] = activity;
+                args[1] = lifecycleEvents;
+                unityPlayer = (UnityPlayer) constructor.newInstance(args);
+            }
+            Log.d(TAG, "UPlayer: UnityPlayer instantiated successfully");
+        } catch (InvocationTargetException e) {
+            Log.e(TAG, "UPlayer: UnityPlayer constructor threw an exception", e.getCause() != null ? e.getCause() : e);
+            throw e;
+        } catch (InstantiationException | IllegalAccessException e) {
+            Log.e(TAG, "UPlayer: failed to instantiate UnityPlayer", e);
+            throw e;
+        }
     }
 
     public static void UnitySendMessage(String gameObject, String methodName, String message) {
@@ -97,13 +154,13 @@ public FrameLayout requestFrame() throws NoSuchMethodException {
 
             return (FrameLayout) getFrameLayout.invoke(unityPlayer);
         } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
-            return unityPlayer;
+            return (FrameLayout)(Object) unityPlayer;
         }
     }
 
     public void setZ(float v) throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         try {
-            Method setZ = unityPlayer.getClass().getMethod("setZ");
+            Method setZ = unityPlayer.getClass().getMethod("setZ", float.class);
 
             setZ.invoke(unityPlayer, v);
         } catch (NoSuchMethodException e) {}

android/src/main/java/com/azesmwayreactnativeunity/UnityEvent.java

@@ -0,0 +1,29 @@
+package com.azesmwayreactnativeunity;
+
+import androidx.annotation.Nullable;
+import com.facebook.react.bridge.Arguments;
+import com.facebook.react.bridge.WritableMap;
+import com.facebook.react.uimanager.events.Event;
+
+public class UnityEvent extends Event<UnityEvent> {
+    private final String mEventName;
+    private final String mMessage;
+
+    public UnityEvent(String eventName, String message, int surfaceId, int viewTag) {
+        super(surfaceId, viewTag);
+        mEventName = eventName;
+        mMessage = message;
+    }
+
+    @Override public String getEventName() { return mEventName; }
+
+    @Override public boolean canCoalesce() { return false; } // events must not be dropped
+
+    @Nullable
+    @Override
+    protected WritableMap getEventData() {
+        WritableMap data = Arguments.createMap();
+        data.putString("message", mMessage);
+        return data;
+    }
+}

ios/RNUnityView.mm

@@ -187,6 +187,11 @@ - (instancetype)initWithFrame:(CGRect)frame {
         gridViewEventEmitter->onUnityMessage(event);
       }
     };
+
+    // Start Unity immediately, don't wait for updateProps
+    if (![self unityIsInitialized]) {
+        [self initUnityModule];
+    }
   }
 
   return self;