fix: AMS slot labels always show 'A' when selecting a non-first AMS unit#10844
Open
BenJule wants to merge 5 commits into
Open
fix: AMS slot labels always show 'A' when selecting a non-first AMS unit#10844BenJule wants to merge 5 commits into
BenJule wants to merge 5 commits into
Conversation
Open
2 tasks
4c066f2 to
3f347c9
Compare
The upstream build_all.yml only listed 'main' as a push trigger. BenJule/BambuStudio uses 'master' as its default branch, so CI never fired on fork-local pushes. Adding 'master' alongside 'main' makes the full multi-platform build run when master is updated.
When a spool has a note, display it as a third sub-line in the Filament column, below the colour/diameter info. The note is truncated with an ellipsis and the full text is available on hover. Rows without a note are unchanged. Closes bambulab#10834
…_filament_gcode templates
The expression {retract_length_toolchange[filament_map[next_extruder]-1]}
directly indexes retract_length_toolchange as a vector in the PlaceholderParser.
When this vector is empty (e.g. due to config compatibility issues with
older 3MF project files), the parser throws "Indexing an empty vector
variable" and slicing fails.
Replace with [new_retract_length_toolchange], the pre-computed scalar
already set in GCode.cpp via full_config.retract_length_toolchange.get_at(),
which handles empty/short arrays safely. For all affected profiles the
default value is 2.0 mm across all extruder variants, so the output is
identical.
Affected templates: X2D, P2S, H2D Pro, H2S (0.4 nozzle)
Fixes bambulab#10437
…ected In the Add Filament / Read from AMS dialog, slotLabels was hardcoded as ['A1','A2','A3','A4'] regardless of which AMS unit was selected. With multi-AMS setups (two or more AMS units attached to the same printer), slots on the second unit would display B1–B4 in every other part of the UI (the filament grouping, the bound_ams_id field, etc.) but the slot picker inside the dialog always showed A1–A4. Fix: derive the unit letter from currentUnit.ams_id (which is '0' for AMS A, '1' for B, etc.) so that slotLabels matches the selected unit. Fixes bambulab#10512
3f347c9 to
7c568f1
Compare
Contributor
Author
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentUnit.ams_id('0'= A,'1'= B, …) and constructslotLabelsdynamically so they always reflect the currently selected AMS unit.Change
One-line change in
AddEditDialog.tsx:Test plan
Fixes #10512