Skip to content

Fix CI token revocation bypass for collection access changes#14

Merged
vitaliimelnychuk merged 1 commit intomainfrom
cursor/-bc-79055579-d86c-4e96-a2d9-5271ede72fe4-9164
Apr 8, 2026
Merged

Fix CI token revocation bypass for collection access changes#14
vitaliimelnychuk merged 1 commit intomainfrom
cursor/-bc-79055579-d86c-4e96-a2d9-5271ede72fe4-9164

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor bot commented Apr 8, 2026

Summary

  • Added a runtime guard for CI token usage to ensure the token creator still has active access to the target collection.
  • Updated /api/ci/file to validate creator access (owner, collection creator, or current direct grant) before returning decrypted content.
  • Added unit tests covering allowed and revoked creator-access scenarios.

Validation

  • npm run test -- src/server/access/access-token-runtime.test.ts src/lib/access-token-hash.test.ts
  • npm run typecheck

Impact

This prevents a revoked user from continuing to read secrets via a previously issued CI token.

Open in Web View Automation 

@vitaliimelnychuk vitaliimelnychuk marked this pull request as ready for review April 8, 2026 15:33
@vitaliimelnychuk vitaliimelnychuk merged commit d5a690f into main Apr 8, 2026
1 check passed
@devactivity-app
Copy link
Copy Markdown

Pull Request Summary by devActivity

Metrics

Cycle Time: 4h 26m Coding Time: < 1 min Review Time: < 1 min

Achievements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants