sinden: virtual-sindenlighgun-add fixes#15885
Open
aderumier wants to merge 3 commits into
Open
Conversation
The guard tested ${ACMDEV}, which was always at least "/dev/" (basename
of an empty string is empty), so it was always true and mono-service
could start with SerialPortWrite="/dev/". Test the find result ${ACM}
instead and only then compute ACMDEV.
The backgrounded mono-service inherited stderr (and stdin) from the udev pipe, keeping the event "in flight" until udev timed out and SIGKILLed the worker, leaving a [virtual-sindenl] <defunct> zombie. Redirect mono-service stdin/stderr (and evsieve stdin) to /dev/null so the worker sees EOF and the event completes promptly.
The lock dir was only removed via unlockAndExit, so a signalled/killed handler leaked it and wedged the gun until reboot (the next replug spins in trylock then gives up). Add a TERM/INT/HUP trap that releases it.
Collaborator
|
@Tovarichtch please confirm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 small fixes for sinden. details are in each commit.