Skip to content

vpinball: bump vpinball and bgfx deps#15978

Open
jsm174 wants to merge 1 commit into
batocera-linux:masterfrom
jsm174:vpinball-deps-4
Open

vpinball: bump vpinball and bgfx deps#15978
jsm174 wants to merge 1 commit into
batocera-linux:masterfrom
jsm174:vpinball-deps-4

Conversation

@jsm174

@jsm174 jsm174 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jsm174

jsm174 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@dmanlfc - I added USE_SYSTEM_LIBS, SYSTEM_LIBS_INCLUDE_DIR, and SYSTEM_LIBS_LIB_DIR and we now have a single CMakeLists file, so no more need to copy or hack the includes/libs paths with sed. Left in draft as my build machine is currently down.

@jsm174 jsm174 force-pushed the vpinball-deps-4 branch from 57ae5d3 to e5bbf0e Compare June 30, 2026 22:05
@jsm174 jsm174 force-pushed the vpinball-deps-4 branch from e5bbf0e to f39d88f Compare June 30, 2026 22:09
@jsm174 jsm174 marked this pull request as ready for review June 30, 2026 22:10
@jsm174

jsm174 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

VPX no longer has a Default_VPinballX.ini asset. This PR also has a minimal change to the configgen so that VPX can be successfully launched on a fresh install. It avoids this error:

  File "/usr/lib/python3.12/site-packages/configgen/emulatorlauncher.py", line 660, in launch
    exitcode = main(args, maxnbplayers)
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/configgen/emulatorlauncher.py", line 67, in main
    return start_rom(args, maxnbplayers, original_rom, original_rom)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/configgen/emulatorlauncher.py", line 179, in start_rom
    cmd = generator.generate(system, rom, player_controllers, md, guns, wheels, gameResolution)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/configgen/generators/vpinball/vpinballGenerator.py", line 40, in generate
    shutil.copy("/usr/bin/vpinball/assets/Default_VPinballX.ini", vpinballConfigFile)
  File "/usr/lib/python3.12/shutil.py", line 435, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.12/shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant