Conversation
ARMv8-m supports 8 different optional extensions. Instead of supporting a curated set permutations, create new constraint setting for each extension.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
The biggest question is if the extensions apply to only arm8-m, or if they are names used throughout the arm 64 big architecture.
I would prefer a solution where we can reuse the names.
|
|
||
| Defines a `constraint_setting`, <name>_setting and two `constraint_values`, | ||
| no_<name> and <name>. | ||
| The setting defaults to `no_<name>` for maximum compatibility, since |
There was a problem hiding this comment.
I don't believe this is needed.
Just create the singleton pair of constraint_setting and constraint_value.
If someone really, really needs to test for a constraint being unset, they can do a select on the constraint value vs. conditions_default.
2 participants
ARMv8-m supports 8 different optional extensions. Instead of supporting a curated set permutations, create new constraint setting for each extension.
This is modeled after #63