Add linux ppc64le binaries for puller and loader #1923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuSarter
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
alexeagle
reviewed
Aug 19, 2021
Contributor
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
I think this may conflict with WIP to build the puller and pusher as part of our releases rather than on the separate pipeline
gravypod
reviewed
Aug 19, 2021
| id: "push-loader-linux-s390x" | ||
| waitFor: ["build-linux-s390x"] | ||
|
|
||
| # Step: build the puller and pusher release binary for Linux ppc64le |
Collaborator
There was a problem hiding this comment.
In addition to the comment that Alex left, CloudBuild is currently disabled for this repo.
Author
Right ! Sorry I missed it. |
Contributor
|
let's work in #1918 instead - we should make sure it has all the os/arch combos that users need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?