Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 89.39% 92.53% +3.13%
==========================================
Files 84 85 +1
Lines 1443 1460 +17
Branches 217 220 +3
==========================================
+ Hits 1290 1351 +61
+ Misses 124 91 -33
+ Partials 29 18 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
forman
requested changes
Mar 11, 2025
Member
There was a problem hiding this comment.
- Why does this work? Please comment.
- Global variable used instead of local memoization
- Why time-consuming JSON conversion instead of suggested shallow comparison
- Missing unit test
This seems to be an insufficient solution as the key used into the map of memoized values is the value serialized itself. But the key should be an ID created from the propertyRef and the value should be the array of input values.
forman
requested changes
Mar 14, 2025
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
forman
requested changes
Mar 14, 2025
forman
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112
This PR also closes xcube-dev/xcube-viewer#490