[Solver / Docs]: Delete the Rust backend and import SciPy instead for better performance and readability#20
Merged
Merged
Conversation
Collaborator
QuentinWach
commented
May 23, 2026
QuentinWach
commented
- Tightened PML validation to reject non-integral values, booleans, and invalid cell/order settings.
- Preserved sweep solver diagnostics when modes are reordered during overlap tracking.
- Added docstrings and clarifying comments across core modules, SciPy solver code, result handling, sweeps, scripts, examples, and benchmarks.
- Expanded tests for PML validation and mode-solver fixture behavior.
- Cleaned up release docs and minor solver formatting.
…file plots, and update documentation accordingly.
- Re-export public API in `__init__.py` for user convenience. - Add detailed comments in `constants.py`, `models.py`, `raster.py`, `result.py`, `scipy_reference.py`, and `sweep.py` to clarify functionality and improve maintainability. - Ensure explicit handling of public interfaces and validation checks in data classes and solver functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.