Skip to content

[Fix]: Fix numerical handling in scipy_reference.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuentinWach merged 1 commit into from
May 23, 2026
Merged

[Fix]: Fix numerical handling in scipy_reference.py #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# micromode

An **electromagnetic mode solver** using the **[FDFD method](https://en.wikipedia.org/wiki/Finite-difference_frequency-domain_method)** on a **[rectilinear Yee-grid](https://en.wikipedia.org/wiki/Finite-difference_time-domain_method)**.
MicroMode is a transparent, grid-first SciPy mode solver for rasterized
photonics workflows.

```bash
pip install micromode
Expand Down
2 changes: 1 addition & 1 deletion python/micromode/scipy_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ def _real_arpack_problem_if_close(matrix, initial_vector: np.ndarray | None, gue
# If the complex part is numerical noise, cast to real to avoid SciPy's
# ComplexWarning path and improve reproducibility.
if np.max(np.abs(matrix_imag)) <= 1e-14 * matrix_scale and guess_is_real:
real_vector = None if initial_vector is None else np.asarray(initial_vector.real, dtype=float)
real_vector = None if initial_vector is None else np.asarray(np.real(initial_vector), dtype=float)
return matrix.real.astype(float), real_vector, float(guess.real)
return matrix, initial_vector, guess

Expand Down
Loading