Merged
Conversation
Contributor
Kampfdackel5
left a comment
There was a problem hiding this comment.
See my comments. Regarding the pipeline: if it works it works!
Member
Author
|
What about you @tillx4, what do you think? |
Contributor
I have no experience with CI, so I would agree, if it works it works, we can adjust stuff later on. A bit sad that cashing for ESP-IDF isn't working as it needs about 5m to install (says so in the checks for this PR at least). But that's something we should do later on, if the core functionality is ensured. merge 🫡 |
Member
Author
|
Yes, sadly I couldn't get caching to work, maybe we find a solution for this in the future. Therefore, the CI will only run on the main branch and for PRs to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CI workflow for building both the frontend and firmware, and refactors the build system to better support prebuilt frontend assets and CI integration. The changes make it easier to supply prebuilt web UI files for firmware builds (critical for CI and reproducibility), while still allowing local builds to generate the UI automatically. Unnecessary complexity and redundant build steps have been removed from the CMake configuration.
CI/CD and Build System Integration:
.github/workflows/esp-build.yml) to build frontend assets with Node.js, collect them as artifacts, and use them in the firmware build, supporting both push and pull request events.CMakeLists.txt,components/vigilant_engine/CMakeLists.txt,main/CMakeLists.txt) to allow firmware builds to consume prebuilt frontend assets via theVE_VIGILANT_HTMLvariable, and to control frontend auto-building with theVE_BUILD_WEBoption. [1] [2] [3] [4]Frontend Build Logic Improvements:
vigilant.htmlfile and uses it if available; otherwise, it builds the frontend automatically if allowed, with improved error handling and messaging for missing dependencies or files. [1] [2]Configuration Defaults:
sdkconfig.defaultsto set the flash size to 4MB by default, which is needed with the size of this project.@tillx4 or @Kampfdackel5 Please review