Add attribution to original java-llama.cpp fork#142
Merged
Conversation
Honors the original java-llama.cpp project by kherud with a prominent blockquote at the top of README.md. https://claude.ai/code/session_01ARt8uaa73YqxMLw1KThMjW
Review Summary✅ Approved — This is a well-executed attribution PR with no issues. Strengths
Analysis
This change embodies good open-source practices and strengthens the project's credibility. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a prominent attribution notice in the README acknowledging that this project is forked from kherud/java-llama.cpp and crediting @kherud for the original work.
Changes
Rationale
This change ensures proper attribution to the original project maintainer and makes the fork relationship transparent to users discovering this repository.
https://claude.ai/code/session_01ARt8uaa73YqxMLw1KThMjW