Make it possible to specify the schema the dump needs to use#31
Open
megawubs wants to merge 1 commit into
Open
Make it possible to specify the schema the dump needs to use#31megawubs wants to merge 1 commit into
megawubs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package loads all available tables from all schemas into memory. This is not ideal when working in a multi-tenant environment as it can slow down the dump significantly when there are a lot of schemas available.
Another problem with loading all tables from all schemas is that it also breaks when another schema has tables that the current schema does not have.
For example, we have a central table that holds all relevant tenant information and some other related tables. In the current setup we need to exclude these tables from the dump. But it shouldn't be loaded in the first place in my opinion.