Skip to content

fix(core): strip trailing slash when looking up localized Makeswift page #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agurtovoy wants to merge 1 commit into
base: integrations/makeswift
Choose a base branch
from
Open

fix(core): strip trailing slash when looking up localized Makeswift page #2950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/forty-trees-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bigcommerce/catalyst-makeswift": patch
---

Fix 404 error on switching between localized Makeswift pages with locale-specific paths when TRAILING_SLASH=true
8 changes: 7 additions & 1 deletion core/vibes/soul/primitives/navigation/_actions/localized-pathname.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,21 @@ const getPageInfo = async ({
const getPathname = (variants: Array<{ locale: string; path: string }>, locale: string) =>
variants.find((v) => v.locale === locale)?.path;

const stripTrailingSlash = (pathname: string) =>
pathname !== '/' ? pathname.replace(/\/+$/, '') : pathname;

export async function getLocalizedPathname({
pathname,
pathname: inputPathname,
activeLocale,
targetLocale,
}: {
pathname: string;
activeLocale: string | undefined;
targetLocale: string;
}) {
// Makeswift page pathnames are always stored without a trailing slash
const pathname = stripTrailingSlash(inputPathname);
Copy link
Copy Markdown
Contributor Author

@agurtovoy agurtovoy Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalize the pathname before looking it up.


// fallback to page info for default locale if there is no page info for active locale
const fallbackPageInfo =
activeLocale === defaultLocale
Expand Down
Loading