support indicator and disabled in chained hx-location requests - #4097
Open
MichaelWest22 wants to merge 1 commit into
Open
MichaelWest22 wants to merge 1 commit into
MichaelWest22 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
indicators and disabled elements can remain after hx-location does a partial replacement that does not replace the main part of the page where the indicators and disabled elements are located. we need to leave the indicators in place while the hx-location does its request as the request cycle is not yet finished which leads to this issue. So to fix this properly we can chain the indicators and disabled elements into the next ajax request by moving these into the ctx object instead of private closures. With this change they stay as tracked and get removed cleanly when the hx-location request completes.
Corresponding issue:
#4090
Testing
Tests needed updating a bit for the new ctx system and added a test for hx-location chaining.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded