Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a swap that replaces the focused element, htmx restores focus by
idand is meant to restore the selection too, but the checktreats
selectionStart === 0as "no selection". A fully selected value always starts at 0. That's exactly what you get when you Tab into a text input, so it is never restored.Common trigger: an input with
hx-trigger="change"whose response re-renders the next field. Leaving the first field via Tab fireschange, the swap recreates the field you just tabbed into, and its selection is lost.Fix:
!= nullstill skips elements without text selection (null) and elements without the property (undefined). This matches the condition the 4.x rewrite already uses in__setFocus.Corresponding issue: none for this case specifically; related to #343 (where selection restoring was introduced).
Testing
Tested manually in Chromium: an input saving on
change, with a response that replaces the next input byouterHTML/ out-of-band swap. Before: after Tab, the next field is focused with selection 0–0. After: the full selection (0–length) survives the swap, and typing replaces the value. Partial selections starting at a non-zero offset behave as before. No new automated test added.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded