[ical4j 4.x] Unify helpers / deduplicate#262
Merged
cketti merged 4 commits intoical4j-3to4from Mar 26, 2026
Merged
Conversation
Use the more generic `Temporal.toLocalDate()` from `TimeApiExtensions` instead.
Use `Temporal.toTimestamp()` from `AndroidTemporalMapper` instead. This function retains ical4j's old behavior when it comes to converting floating DATE and DATE-TIME values to a timestamp.
Move the class to a more generic package since it's not exclusively used by the calendar code.
ArnyminerZ
approved these changes
Mar 26, 2026
lib/src/main/kotlin/at/bitfire/synctools/util/AndroidTemporalMapper.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/util/AndroidTemporalMapper.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporal.toLocalDate()fromTimeApiExtensionsinstead ofInstant.toLocalDate()fromDateUtils.Temporal.toTimestamp()fromAndroidTemporalMapperinstead ofTemporal.toEpochMilli()fromDateUtils. The former one retains ical4j's old behavior when it comes to converting floating DATE and DATE-TIME values to a timestamp.AndroidTemporalMapperfrom thecalendarpackage to a more genericutilpackage since it's not exclusively used by the calendar code.