Conversation
sunkup
force-pushed
the
256-ical4j-4x-fix-failing-jtx-board-tests
branch
from
79b8666 to
cb9c22e
Compare
sunkup
force-pushed
the
256-ical4j-4x-fix-failing-jtx-board-tests
branch
from
6ae3e03 to
ca2d8c1
Compare
|
@cketti You removed the I added you as a reviewer here because of that change :) |
Use |
Ok. Tests fail then, so seems like it behaves slightly different. I will investigate that. Edit: Zone offset was wrong by 2 ours when using |
…toEpochMilli again
| iCalObject.rdate = rdateList.toTypedArray().joinToString(separator = ",") | ||
| iCalObject.rdate = buildList { | ||
| if(!iCalObject.rdate.isNullOrEmpty()) | ||
| add(JtxContract.getLongListFromString(iCalObject.rdate!!)) |
There was a problem hiding this comment.
This needs to be be addAll().
| iCalObject.exdate = exdateList.toTypedArray().joinToString(separator = ",") | ||
| iCalObject.exdate = buildList { | ||
| if(!iCalObject.exdate.isNullOrEmpty()) | ||
| add(JtxContract.getLongListFromString(iCalObject.exdate!!)) |
There was a problem hiding this comment.
This needs to be be addAll().
| private fun addProperties(props: PropertyList) { | ||
| uid.let { props += Uid(it) } | ||
| sequence.let { props += Sequence(it.toInt()) } | ||
| private fun addProperties(props: PropertyList): PropertyList? { |
There was a problem hiding this comment.
Tip for the future: If you renamed the function parameter and used the name props for the mutable list, the body could have remained mostly unchanged. That makes the change easier to review.
3 participants
Made some mistakes when updating
JtxICalObjectthis PR fixes them.add()andaddAll()for lists from ical4j, don't alter the existing list, but instead return a a copy with the added elements. Always use that new list.when{}blocks for simplicityAlso fixes empty VTODOs being uploaded (#250).