Remove jCard support and simplify vCard writing#265
Merged
Conversation
- Remove `writeJCard` and `testWriteJCard` methods - Remove jCard-related parameters and imports - Simplify `writeCard` to `writeVCard` with single implementation - Update tests to use `writeVCard` instead of `writeCard`
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused jCard support and consolidates vCard writing to a single vCard-only implementation.
Changes:
- Removed jCard-specific reader/writer support and related custom-scribe helpers.
- Renamed/simplified
ContactWriter.writeCard(...)towriteVCard(...)(vCard-only). - Updated vCard writing tests to use
writeVCard.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/src/test/kotlin/at/bitfire/vcard4android/ContactWriterTest.kt | Removes jCard test and updates tests to call writeVCard. |
| lib/src/main/kotlin/at/bitfire/vcard4android/property/CustomScribes.kt | Removes jCard-specific registerCustomScribes extensions and imports. |
| lib/src/main/kotlin/at/bitfire/vcard4android/ContactWriter.kt | Removes jCard writing path; keeps one vCard writer implementation via writeVCard. |
| lib/src/main/kotlin/at/bitfire/vcard4android/Contact.kt | Removes jCard parsing/writing APIs and simplifies fromReader signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove unused `downloader` parameter from `Contact.fromReader` method - Update test cases to reflect the change
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jCard is to be removed because it's not used and dead code that shouldn't be necessary to maintain (bitfireAT/davx5-ose#2079).
This pull request removes jCard support and simplifies the vCard writing process by:
writeJCardandtestWriteJCardmethodswriteCardtowriteVCardwith a single implementationwriteVCardinstead ofwriteCard