feat: center markdown images in docs by default#40
Merged
Julusian merged 2 commits intobitfocus:mainfrom Mar 1, 2026
Merged
Conversation
This improves readability and simplifies some cases. (A complete search of the repo did not reveal any cases in which this breaks the current text-flow, i.e. by breaking up a single line.) Note a nice side-effect is that the image will always appear on its own line. (If you need to override this, it should be possible with inline html/style.) Note: this is prelude to an internal reformat of for-developers (i.e. reformat the files with essentially no change to the built website)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds a CSS rule targeting Changes
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Using p > img (suggested in PR bitfocus#42) leads to too many edge-cases that fail. For example, if the image is clickable, i.e. inside `<a>`. The following is more robust and still overrideable by adding an element after it (such as <span>).
arikorn
added a commit
to arikorn/companion-website
that referenced
this pull request
Mar 1, 2026
(sync with PR bitfocus#40) Using p > img (suggested in PR bitfocus#42) leads to too many edge-cases that fail. For example, if the image is clickable, i.e. inside `<a>`. The following is more robust and still overrideable by adding an element after it (such as <span>).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves readability and simplifies some cases. (A complete search of the repo did not reveal any cases in which this breaks the current text-flow, i.e. by breaking up a single line.)
Note a nice side-effect is that the image will always appear on its own line. (If you need to override this, it should be possible with inline html/style.)
Note: this is prelude to an internal reformat of for-developers (i.e. reformat the files with essentially no change to the built website)
Summary by CodeRabbit