Android: log full exceptions instead of just their message - #31
Merged
Conversation
Several catch blocks called CodePushUtils.log(String) with only e.getMessage(), even though the exception object was already in hand. That silently drops the stack trace from logcat, since only CodePushUtils.log(Throwable) actually prints it (via Log.e). Switch those sites to log the Throwable itself, preserving the original context in a wrapping message where one existed.
There was a problem hiding this comment.
Pull request overview
Updates Android error logging to preserve stack traces and exception causes.
Changes:
- Logs malformed-data exceptions directly.
- Wraps reflective bundle-loading failures with contextual messages and causes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CodePushNativeModule.java |
Preserves stack traces in bundle-loading error logs. |
CodePush.java |
Logs malformed package-data exceptions directly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ofalvai
marked this pull request as ready for review
August 17, 2026 09:09
zoltanszabo-bitrise
approved these changes
Aug 17, 2026
sajtizsolt
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a list of quick tactical logging fixes.
Several catch blocks called
CodePushUtils.log(String)with onlye.getMessage(), even though the exception object was already in hand. That silently drops the stack trace from logcat, since onlyCodePushUtils.log(Throwable)actually prints it (viaLog.e). Switch those sites to log theThrowableitself, preserving the original context in a wrapping message where one existed.