Skip to content

Conversation

@BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28413

📔 Objective

Removes feature flagged logic for bulk re-invite.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner January 26, 2026 20:04
@BTreston BTreston requested a review from jrmccannon January 26, 2026 20:04
@BTreston BTreston changed the title remove feature flagged logic [PM-28413] Remove feature flagged logic Jan 26, 2026
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd0266c2a-f501-473f-b9de-ccf0d3c11208

Great job! No new security vulnerabilities introduced in this pull request

jrmccannon
jrmccannon previously approved these changes Jan 27, 2026
@jrmccannon jrmccannon dismissed their stale review January 27, 2026 14:17

I see tests are failing. sorry.

@BTreston BTreston requested a review from jrmccannon January 27, 2026 14:30
@BTreston
Copy link
Contributor Author

@jrmccannon There's an issue with tests timing out recently (UI PR), I'm re-running them now.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.08%. Comparing base (5104ec5) to head (8e90687).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6901   +/-   ##
=======================================
  Coverage   56.08%   56.08%           
=======================================
  Files        1968     1968           
  Lines       86974    86952   -22     
  Branches     7748     7745    -3     
=======================================
- Hits        48780    48768   -12     
+ Misses      36387    36378    -9     
+ Partials     1807     1806    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jrmccannon jrmccannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the tests pass. Carry on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants