Skip to content

Conversation

@jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 26, 2026

🎟️ Tracking

PM-29228

📔 Objective

This renames the method on the AutoConfirm requirement to be more explicit as to how the policy relates to Emergency Access.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon changed the title Renamed for clarity [PM-29228] - Auto Confirm Requriement Emergency Access Jan 26, 2026
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0aaad6c9-14e5-4dc9-b8de-0089e7d568b3

Great job! No new security vulnerabilities introduced in this pull request

@jrmccannon jrmccannon added the ai-review Request a Claude code review label Jan 26, 2026
@jrmccannon jrmccannon marked this pull request as ready for review January 26, 2026 21:03
@jrmccannon jrmccannon requested a review from a team as a code owner January 26, 2026 21:03
@jrmccannon jrmccannon requested a review from r-tome January 26, 2026 21:03
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (2a45880) to head (4135451).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ents/AutomaticUserConfirmationPolicyRequirement.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6902   +/-   ##
=======================================
  Coverage   56.08%   56.09%           
=======================================
  Files        1968     1968           
  Lines       86974    86974           
  Branches     7748     7748           
=======================================
+ Hits        48783    48784    +1     
+ Misses      36385    36384    -1     
  Partials     1806     1806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccannon jrmccannon merged commit 898904a into main Jan 27, 2026
47 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-29228-auto-confirm-no-emergency-access branch January 27, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants