IDETECT-5134 : fix(pnpm): use UTF-8 encoding when reading pnpm-lock.yaml to handle emojis and non-ASCII characters#1793
Open
bd-spratikbharti wants to merge 4 commits into
Open
IDETECT-5134 : fix(pnpm): use UTF-8 encoding when reading pnpm-lock.yaml to handle emojis and non-ASCII characters#1793bd-spratikbharti wants to merge 4 commits into
bd-spratikbharti wants to merge 4 commits into
Conversation
bd-spratikbharti
requested review from
bd-samratmuk,
Copilot,
dterrybd and
zahidblackduck
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses pnpm lockfile parsing failures on systems where the JVM default charset is not UTF-8 (notably Windows), by explicitly reading pnpm-lock.yaml as UTF-8 before passing it to SnakeYAML.
Changes:
- Replace
FileReaderwithInputStreamReader+StandardCharsets.UTF_8forpnpm-lock.yamlparsing. - Update the project snapshot version string in
build.gradle.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| detectable/src/main/java/com/blackduck/integration/detectable/detectables/pnpm/lockfile/process/PnpmLockYamlParserInitial.java | Enforces UTF-8 when reading pnpm-lock.yaml for SnakeYAML parsing. |
| build.gradle | Bumps snapshot version identifier for this change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FileReaderuses the JVM's platform-default charset, which can garbleemojis and non-ASCII characters in pnpm-lock.yaml on Windows or
non-UTF-8 systems, causing SnakeYAML to fail.
Replaced both
FileReaderusages withInputStreamReader+StandardCharsets.UTF_8to explicitly enforce UTF-8.No logic changes.