Skip to content

fix(acp): reply to top-level DMs - #6988

Open
ScaleLeanChris wants to merge 1 commit into
block:mainfrom
ScaleLeanChris:codex/fix-buzz-6984-top-level-dm
Open

fix(acp): reply to top-level DMs#6988
ScaleLeanChris wants to merge 1 commit into
block:mainfrom
ScaleLeanChris:codex/fix-buzz-6984-top-level-dm

Conversation

@ScaleLeanChris

Copy link
Copy Markdown

Summary

  • Give every DM turn the triggering event as its reply anchor.
  • Use the existing new-thread send instruction for top-level DMs.
  • Correct the existing queue test that encoded the missing-instruction behavior.

Root cause

format_prompt did not produce a reply anchor for a top-level DM, and format_context_hints only emitted a send instruction inside the threaded-DM branch. The harness could therefore complete the ACP turn without calling buzz messages send.

Top-level DMs should no longer end in the sound of silence.

Verification

  • cargo test -p buzz-acp test_reply_instruction_present_for_top_level_dm
  • cargo test -p buzz-acp queue::tests (138 passed)
  • cargo test -p buzz-acp (830 unit tests and 9 lifecycle tests passed)
  • cargo clippy -p buzz-acp --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • just ci (passed, including 1,874 mobile tests)

Live relay verification was not run against this source build. The regression test exercises the prompt sent to the harness and asserts the exact reply anchor and new-thread instruction.

Closes #6984

Signed-off-by: ScaleLeanChris <chris@scalelean.com>
@ScaleLeanChris
ScaleLeanChris requested a review from a team as a code owner August 28, 2026 15:33
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is e76c81968b65b0755b83efdd59dc3375c59ddf40...6a766d121e2ec0b6ba89307267ae2870f443feba.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 6a766d121e2ec0b6ba89307267ae2870f443feba to authorize a new review.
Any previous review applies only to its recorded range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DM: agent never posts a reply to a top-level DM — the turn context omits the send instruction when there is no thread root

1 participant