fix(acp): reply to top-level DMs - #6988
Open
ScaleLeanChris wants to merge 1 commit into
Open
Conversation
Signed-off-by: ScaleLeanChris <chris@scalelean.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
format_promptdid not produce a reply anchor for a top-level DM, andformat_context_hintsonly emitted a send instruction inside the threaded-DM branch. The harness could therefore complete the ACP turn without callingbuzz messages send.Top-level DMs should no longer end in the sound of silence.
Verification
cargo test -p buzz-acp test_reply_instruction_present_for_top_level_dmcargo test -p buzz-acp queue::tests(138 passed)cargo test -p buzz-acp(830 unit tests and 9 lifecycle tests passed)cargo clippy -p buzz-acp --all-targets --all-features -- -D warningscargo fmt --all -- --checkjust ci(passed, including 1,874 mobile tests)Live relay verification was not run against this source build. The regression test exercises the prompt sent to the harness and asserts the exact reply anchor and new-thread instruction.
Closes #6984