refactor: Move base_channel_type_impl to detail namespace#681
Draft
marco-langer wants to merge 2 commits intoboostorg:developfrom
Draft
refactor: Move base_channel_type_impl to detail namespace#681marco-langer wants to merge 2 commits intoboostorg:developfrom
marco-langer wants to merge 2 commits intoboostorg:developfrom
Conversation
Member
|
@marco-langer Why closing? |
Contributor
Author
|
@mloskot I wanted to discuss this PR with you before working on it again, but I thought currently the Boost 1.80 PRs are more important. I think those structs belong to the detail namespace, but they are currently not. However, just moving stuff around would violate boosts deprecation policy, right? So, some of my solutions:
|
Member
|
OK. You can always turn PR to Draft.
Yes, indeed.
Generally speaking, yes. Let's postpone it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves base_channel_type_impl to detail namespace.
Tasklist