Skip to content

fix: transitive closure was not testing correctness - #560

Open
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/fold-transitive-closure-tests
Open

fix: transitive closure was not testing correctness#560
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/fold-transitive-closure-tests

Conversation

@Becheler

Copy link
Copy Markdown
Collaborator

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

  • Folds a print-only test into transitive closure test, and actually test it
  • Modernize the test file by bringing BOOST_TEST in
  • Refactor to limit verbosity and complexity

Motivation

Flickering CI coverage, and untested test files are not great.

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler self-assigned this Aug 10, 2026
@Becheler Becheler added technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. test Adding, fixing or modernizing unit tests labels Aug 10, 2026
@Becheler
Becheler force-pushed the fix/fold-transitive-closure-tests branch from a9a0064 to f602d36 Compare August 10, 2026 18:16
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 31467881423 vs develop run 31467777307 (09646e7664).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 31467881369 vs develop run 31467777283 (09646e7664).

Job Baseline After Delta
macos (clang, 14) 681 676 -5
macos (clang, 17) 641 636 -5
macos (clang, 20) 641 636 -5
ubuntu (clang-19, 14) 681 676 -5
ubuntu (clang-19, 17) 641 636 -5
ubuntu (clang-19, 20) 641 636 -5
ubuntu (clang-19, 23) 641 636 -5
ubuntu (gcc-14, 14) 827 823 -4
ubuntu (gcc-14, 17) 949 945 -4
ubuntu (gcc-14, 20) 949 945 -4
ubuntu (gcc-14, 23) 949 945 -4
windows_msvc_14_3 (msvc-14.3) 962 962 0

@Becheler
Becheler force-pushed the fix/fold-transitive-closure-tests branch 4 times, most recently from 23ceef1 to 62c3a25 Compare August 10, 2026 19:53
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler force-pushed the fix/fold-transitive-closure-tests branch 2 times, most recently from be33376 to 9f6fd2b Compare August 11, 2026 06:06
@Becheler
Becheler force-pushed the fix/fold-transitive-closure-tests branch from 9f6fd2b to 09646e7 Compare August 11, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. test Adding, fixing or modernizing unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant