Fix 2382: apply correct layout to password reset - #2550
Open
javiercoronadonarvaez wants to merge 2 commits into
Open
Fix 2382: apply correct layout to password reset#2550javiercoronadonarvaez wants to merge 2 commits into
javiercoronadonarvaez wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe auth page’s standalone tablet breakpoint was removed. Its single-column layout and content alignment rules were moved into the mobile breakpoint, which retains mobile illustration heights and uses explicit top, inline, and bottom padding. ChangesAuth page responsive layout
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2382
Summary & Context
Fixes the password-reset (auth page) layout so tablet renders the two-column desktop layout instead of the mobile stack, and tightens up mobile spacing to match Figma. Changes live entirely in the shared
auth-page.css, so they apply to every password-reset screen (and the other auth pages that reuse the layout)./done/,/key/<uidb36>-<key>/,/key/done/)Changes
max-width: 1279pxdown tomax-width: 767pxso the two-column layout (illustration left, form right) persists across the tablet range instead of collapsing to the mobile stack.592px/500px). The mobile sizing (368px/280px) now lives in the single≤767pxblock.var(--space-card)) and increased the illustration heading gap to 56px to match Figma (was 8px).Please list any potential risks or areas that need extra attention during review/testing
auth-page.cssalso backs sign-in and sign-up. The breakpoint change makes those pages two-column on tablet as well (the intended "match desktop" behavior), so please spot-check sign-in / sign-up at tablet widths, not just the password screens.768px(Tailwindmd). Widths in the 768–1279px range that previously stacked will now show two columns — verify nothing looks cramped in that range, especially the taller sign-up form.56px. No spacing token matches it (56px exceeds the largest mobile token,--space-xxl= 48px) because the value comes from Figma's vertical centering rather than a token. Sides and bottom remain tokenized (--space-card,--space-xxl).Screenshots
Mobile
Tablet
Self-review Checklist
Frontend
Summary by CodeRabbit