fix: floor bounty amounts in issue meta titles#1604
Open
santoslgl01-web wants to merge 1 commit intobountysource:masterfrom
Open
fix: floor bounty amounts in issue meta titles#1604santoslgl01-web wants to merge 1 commit intobountysource:masterfrom
santoslgl01-web wants to merge 1 commit intobountysource:masterfrom
Conversation
Author
|
Hi! Just checking in — please let me know if any changes are needed. Happy to update the PR. Thanks! 🙂 |
Author
|
Hi! Just checking in — please let me know if any changes are needed. Happy to update the PR. Thanks! |
Author
|
Hi! Just checking in \u2014 please let me know if any changes are needed. Happy to update the PR. Thanks! \ud83d\ude42 |
Author
|
Hi! Just checking in — please let me know if any changes are needed. Happy to update the PR. Thanks! 🙂 |
Author
|
Hi! Just checking in on this PR — please let me know if any changes are needed. Happy to update it. Thanks! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #566
This updates issue meta-title bounty formatting to floor fractional dollar amounts before rendering whole-dollar labels, matching the behavior already described for badges/GitHub plugin output. For example,
$5.50now renders as$5instead of rounding up to$6.Changes
Testing
git diff --checkbundle exec rspec spec/helpers/issue_meta_tags_helper_spec.rbcould not run in this environment because the project requires Ruby 2.7.1, while the available Ruby is 2.6.10 and Bundler refused to install/run gems.