Open
Conversation
9e23ca9 to
7402bb0
Compare
7402bb0 to
9845abc
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the Zeebe variable extraction test suite to cover additional scoping/mapping scenarios, including agentic ad-hoc sub-processes using zeebe:adHoc#outputCollection, and updates a few related dependencies.
Changes:
- Add new Zeebe BPMN fixtures + spec coverage for sub-process scoping edge cases, connector output mapping, connector sub-process scoping, and agentic ad-hoc sub-process variables.
- Improve
variableEqualassertion diagnostics in tests. - Bump
@bpmn-io/lezer-feeland@bpmn-io/properties-panel(plus related lockfile updates).
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/zeebe/ZeebeVariableResolver.spec.js | Adds/adjusts tests for new scoping + agentic ad-hoc coverage; switches some calls to pass diagram elements. |
| test/globals.js | Updates the custom variableEqual chai assertion to provide more descriptive failure messages. |
| test/fixtures/zeebe/sub-process.no-output-mapping.bpmn | New fixture for sub-process scoping without output mapping. |
| test/fixtures/zeebe/connectors.sub-process.bpmn | New fixture for connectors inside a sub-process. |
| test/fixtures/zeebe/connectors.output-mapping.bpmn | New fixture for connector output mappings. |
| test/fixtures/zeebe/connectors.bpmn | Extends existing connector fixture with an additional participant/sub-process scenario. |
| test/fixtures/zeebe/complex.sub-process-mapping-conflict.bpmn | New fixture for conflicting mapping behavior. |
| test/fixtures/zeebe/ad-hoc-sub-process.agentic.bpmn | New agentic ad-hoc sub-process fixture using zeebe:adHoc outputCollection. |
| package.json | Dependency bumps for FEEL parser + properties panel. |
| package-lock.json | Lockfile updates reflecting dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* outputCollection defines variable * validate agentic use-case
9845abc to
f04ca51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Support
<zeebe:adHoc outputCollection="..." />definition, to make variables visible in agentic use-cases:Defines the following variables (assuming
toolCallResultandtoolCallResultsareAI Agentlocal variables:Depends on bpmn-io/extract-process-variables#34
Related to camunda/camunda-modeler#5606
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool