fix: Declare merged_git_metadata_settings before usage#10
Merged
AbhiPrasad merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
realark
approved these changes
Feb 26, 2026
Qard
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8
AI Summary
Fix: One-line initialization at
logger.py:1642—merged_git_metadata_settings = NoneBug: When
repo_infois passed tobraintrust.init(), the code skips theelseblock wheremerged_git_metadata_settingsgets assigned (line 1646), but later references it unconditionally on line 1660. This causes anUnboundLocalErrorwheneverbase_experiment_idandbase_experimentare bothNone(the default).Fix behavior: Initializing to
Nonebefore theif/elseensures the variable is always defined. SinceNoneis falsy, theelifon line 1660 short-circuits correctly — skipping ancestor commit collection, which is the right behavior when the user explicitly providesrepo_info.Test: Added
test_init_with_repo_info_does_not_raiseintest_logger.pythat callsbraintrust.init(project=..., repo_info=RepoInfo(...))and forcescompute_metadata()to execute. Verified it fails withUnboundLocalErrorwithout the fix and passes with it.