Merged
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
nselvidge
reviewed
Feb 23, 2026
nselvidge
left a comment
nselvidge
left a comment
There was a problem hiding this comment.
I'm not too bullish on moving off of --dev, bringing that up as a discussion point here. I do think we should fix the org check logic though if I'm reading it correctly.
Comment on lines
+243
to
+251
| pub dev: bool, | ||
|
|
||
| /// Host interface for eval dev server. | ||
| #[arg(long, default_value = "localhost")] | ||
| pub dev_host: String, | ||
|
|
||
| /// Port for eval dev server. | ||
| #[arg(long, default_value_t = 8300)] | ||
| pub dev_port: u16, |
There was a problem hiding this comment.
I know that the current cli all use --dev but imo it isn't clear why we would call this a "dev server". imo using --serve seems more intuitive. maybe porting to a new CLI is an opportunity to clarify this?
we don't refer to this as a "dev server" anywhere except for the cli flag name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.