Fix login redirect#256
Merged
Merged
Conversation
Ankur Goyal (ankrgyl)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Cedric / ViaDézo1er (viadezo1er)
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Abhijeet Prasad (AbhiPrasad)
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "continue to redirect url" thing sometimes hung. I replaced the hacky socket reading we were doing with a simple actix webserver (something we were already using). Also fixed the ergonomics of re-logging into an existing profile (select the existing org choice by default and do not show a scary "overwrite" message if you select it).