Open
Conversation
parkerhendo
force-pushed
the
parker/eval-not-esm-bug
branch
from
f991d90 to
44933b4
Compare
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
parkerhendo
changed the title
ibolmo
reviewed
Feb 25, 2026
| const preferRequire = | ||
| file.endsWith(".ts") || file.endsWith(".tsx") || file.endsWith(".cjs"); | ||
| !forceEsm && | ||
| (file.endsWith(".ts") || file.endsWith(".tsx") || file.endsWith(".cjs")); |
There was a problem hiding this comment.
there might be some overlap with similar findings here:
There was a problem hiding this comment.
more tests here: https://github.com/braintrustdata/bt/pull/40/changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"type": "module"with only"import"exports), tsx v4 fails because it compiles .ts → CJS regardless of load method. The CJSrequire()can't match the"import"condition in package.json exports, producingERR_PACKAGE_PATH_NOT_EXPORTED.BT_EVAL_FORCE_ESM=1, which skips therequire()path in the eval-runner and uses Vite's bundler-based module resolution instead.eval-ts-esm-only-dep) with a local ESM-only package to verify the fix.Test plan
cargo test eval_fixturespasses with the neweval-ts-esm-only-depfixturebt eval --runner tsxagainst a project with ESM-only deps retries and succeeds