Conversation
knjiang
changed the title
knjiang
commented
Feb 24, 2026
knjiang
commented
Feb 24, 2026
knjiang
commented
Feb 24, 2026
| @@ -0,0 +1,59 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
snapshots are generated straight from params.ts
knjiang
commented
Feb 24, 2026
| @@ -0,0 +1,33 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
transforms are generated bby taking the payload of params.ts of an openai test case and just swapping the model in for an anthropic/gemini model
they are then recorded in directory of chat_completions_to_x
aswink
approved these changes
Feb 24, 2026
Contributor
aswink
left a comment
aswink
left a comment
There was a problem hiding this comment.
LGTM, though I wonder if choosing between tool choice and reasoning should be an option somewhere. It's not clear to me that preferring tool choice is always what users will want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this diff,
chat_completions_to_anthropicwould emit:{ "error": "400 {\"type\":\"error\",\"error\":{\"type\":\"invalid_request_error\",\"message\":\"Thinking may not be enabled when tool_choice forces tool use.\"},\"request_id\":\"req_011CYTRzwy2T1KfQDz2t7Xg4\"}", "name": "Error" }