Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aswink
force-pushed
the
aswin/02-26-remove_retries
branch
from
e18f58f to
4b5c643
Compare
aswink
commented
Feb 26, 2026
| Self { | ||
| connect_timeout: Duration::from_secs(10), | ||
| request_timeout: Duration::from_secs(300), | ||
| // Similar to what anthropic and openai SDKs use |
Contributor
Author
There was a problem hiding this comment.
Not really related to the rest of the change, happy to drop it if it seems unnecessary. Though I do wonder if we'll need the higher request timeout
knjiang
reviewed
Feb 26, 2026
Contributor
knjiang
left a comment
knjiang
left a comment
There was a problem hiding this comment.
just one comment to think through. i'm not sure if i totally like passing a retry policy throiugh but that was my first thought
aswink
force-pushed
the
aswin/02-26-remove_retries
branch
from
a73b975 to
0395cea
Compare
knjiang
approved these changes
Feb 27, 2026
aswink
force-pushed
the
aswin/02-26-remove_retries
branch
3 times, most recently
from
f8ef27f to
e02a55a
Compare
Contributor
Author
|
CI passes on the main repo: https://github.com/braintrustdata/braintrust/pull/11253 |
aswink
force-pushed
the
aswin/02-26-remove_retries
branch
from
f7a3b61 to
0483aa0
Compare
lingua is more intended to do provider translation than request/retry semantics, so remove retries from this library. Callers can take care of retries themselves.
aswink
force-pushed
the
aswin/02-26-remove_retries
branch
from
0483aa0 to
1b8fc29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lingua is more intended to do provider translation than request/retry
semantics, so remove retries from this library. Callers can take care of
retries themselves.