Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/pg/lib/query.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,10 @@ class Query extends EventEmitter {
err = this._canceledDueToError
this._canceledDueToError = false
}
// if callback supplied do not emit error event as uncaught error
// events will bubble up to node process
if (this.callback) {
return this.callback(err)
if (this.listenerCount('error') > 0) {
this.emit('error', err)
}
this.emit('error', err)
if (this.callback) return this.callback(err)
}

handleReadyForQuery(con) {
Expand Down
20 changes: 20 additions & 0 deletions packages/pg/test/unit/client/query-timeout-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,23 @@ test('query timeout with Submittable with callback delivers error via callback',
done()
})
})

test('handleError emits error even when callback is present', function (done) {
const query = new Query({ text: 'SELECT 1' })
const err = new Error('boom')
let emitted = false
let called = false

query.on('error', (emittedErr) => {
assert.equal(emittedErr, err)
emitted = true
if (called) done()
})
query.callback = (callbackErr) => {
assert.equal(callbackErr, err)
called = true
if (emitted) done()
}

query.handleError(err)
})
Loading