docs: add Google Ads navigation routes - #576
Conversation
✅ Skill review passedReviewed 1 file(s) — no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce2b5e2bde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,24 @@ | |||
| # Google Ads navigation and read-only extraction | |||
There was a problem hiding this comment.
Make the skill discoverable for ads.google.com
When navigation starts at the documented https://ads.google.com/... URL, goto() derives the skill directory from the hostname's first label (helpers.py:52), so it checks domain-skills/ads, not domain-skills/google-ads. Consequently, the harness omits this new document from the domain_skills returned during normal Google Ads navigation; rename the directory to ads or add an explicit hostname-to-skill mapping.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="domain-skills/google-ads/routes.md">
<violation number="1" location="domain-skills/google-ads/routes.md:1">
P2: This document is placed under domain-skills/google-ads/, but the navigation harness's goto() derives the skill directory from the hostname's first label (ads.google.com -> 'ads'), per helpers.py:52. That means this file won't be discovered/returned in domain_skills during normal Google Ads navigation. Consider renaming the directory to domain-skills/ads or adding an explicit hostname-to-skill mapping so this documentation is actually surfaced.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| @@ -0,0 +1,24 @@ | |||
| # Google Ads navigation and read-only extraction | |||
There was a problem hiding this comment.
P2: This document is placed under domain-skills/google-ads/, but the navigation harness's goto() derives the skill directory from the hostname's first label (ads.google.com -> 'ads'), per helpers.py:52. That means this file won't be discovered/returned in domain_skills during normal Google Ads navigation. Consider renaming the directory to domain-skills/ads or adding an explicit hostname-to-skill mapping so this documentation is actually surfaced.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At domain-skills/google-ads/routes.md, line 1:
<comment>This document is placed under domain-skills/google-ads/, but the navigation harness's goto() derives the skill directory from the hostname's first label (ads.google.com -> 'ads'), per helpers.py:52. That means this file won't be discovered/returned in domain_skills during normal Google Ads navigation. Consider renaming the directory to domain-skills/ads or adding an explicit hostname-to-skill mapping so this documentation is actually surfaced.</comment>
<file context>
@@ -0,0 +1,24 @@
+# Google Ads navigation and read-only extraction
+
+## Account routes
</file context>
Summary
Verification
Summary by cubic
Add docs for Google Ads navigation and read-only extraction. Covers correct routes (campaigns, ad groups, ads, keywords, search terms, conversions, auto-apply), stable
essfieldselectors andaria-labelvalues, virtualization scrolling, checkbox state viaaria-checked, the/aw/searchterms404, and ad-blocker warning handling.Written for commit ce2b5e2. Summary will update on new commits.